fix: error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
reviewed
Dec 7, 2021
| - Fixed NetworkObjects not being despawned before they are destroyed during shutdown for client, host, and server instances. (#1390) | ||
| - Fixed client player object being destroyed on server when the client's player object has DontDestroyWithOwner set. (#1433) | ||
| - Fixed: NetworkVariables containing more than 1300 bytes of data (such as large NetworkLists) no longer cause an OverflowException (the limit on data size is now whatever limit the chosen transport imposes on fragmented NetworkDelivery mechanisms) (#1481) | ||
| - Fixed: Fixed: Fixed error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1509) |
Contributor
There was a problem hiding this comment.
"Fixed: Fixed: Fixed error ..." :P
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| - Fixed: Fixed: Fixed error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1509) | |
| - Fixed: Fixed: Fixed: Fixed: Corrected error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1509) |
0xFA11
reviewed
Dec 7, 2021
Contributor
0xFA11
left a comment
0xFA11
left a comment
There was a problem hiding this comment.
lgtm but I'd like to defer to @NoelStephensUnity
mattwalsh-unity
approved these changes
Dec 7, 2021
com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs
Show resolved
Hide resolved
NoelStephensUnity
approved these changes
Dec 7, 2021
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Nice adjustment to work around the scene object count.
LGTM!
This was referenced Feb 17, 2022
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…gement disabled when one or more objects is hidden via the CheckObjectVisibility delegate (Unity-Technologies#1509) * fix: error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate * Changelog * standards * Fixed the "Fixed: Fixed: Fixed", fixing the "fixed" count so it's fixed at 2 fixeds. Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1847
fixes #1445
Changelog
com.unity.netcode.gameobjects
Testing and Documentation