fix: m_ListAtLastReset and dynamically spawned objects#2065
Merged
Conversation
… an in-scene placed object. Addresses consistency issues in NetworkList for spawned objects
0xFA11
suggested changes
Jul 18, 2022
Contributor
0xFA11
left a comment
0xFA11
left a comment
There was a problem hiding this comment.
can we have a descriptive bugfix entry in the changelog please? :)
jeffreyrainy
force-pushed
the
fix/in-scene-networklist
branch
from
8b750b2 to
79acf4d
Compare
0xFA11
reviewed
Jul 18, 2022
jeffreyrainy
commented
Jul 18, 2022
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
0xFA11
reviewed
Jul 18, 2022
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
0xFA11
approved these changes
Jul 18, 2022
This was referenced Jul 19, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limiting the use of the m_ListAtLastReset to cases where we have an in-scene placed object. Addresses consistency issues in NetworkList for spawned objects. Addresses #2062 and #1983 Jira: MTT-4085 and MTT-4089
Uses the
m_ListAtLastResetofNetworkListonly for in-scene placed object. Uses the normalm_Listfor spawned objects.