fix: initializing the LastSentState when spawning the NetworkTransform [MTT-3044] #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @NoelStephensUnity since you're looking at this same code right now. |
| TryCommitTransformToServer(m_Transform, m_CachedNetworkManager.LocalTime.Time); | ||
| } | ||
| m_LocalAuthoritativeNetworkState = m_ReplicatedNetworkState.Value; | ||
| m_LastSentState = m_LocalAuthoritativeNetworkState = m_ReplicatedNetworkState.Value; |
Collaborator
There was a problem hiding this comment.
I will look into this issue in #2102 since there are some adjustments that could fix the issue you might be experiencing with client-side authority. m_LastSentState should be only set by the authority as that is all it is used for, and this change will set it on both non-authoritative and authoritative (although setting it on the non-authoritative side shouldn't have any real impact to non-authoritative instances).
Collaborator
|
@LPLafontaineB |
LPLafontaineB
deleted the
fix/last-sent-state-not-initialized-network-transform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply makes sure that m_LastSentState is initialized when the NetworkTransform is spawned. Not initializing it caused an issue with the ClientNetworkTransform where spawning it with client ownership would have the client send the uninitialized m_LastSentState to the server during the first Update, which could lead to the client and server versions having different rotations.
Changelog
Testing and Documentation