Skip to content

fix: initializing the LastSentState when spawning the NetworkTransform [MTT-3044] #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: initializing the LastSentState when spawning the NetworkTransform [MTT-3044] #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b6340
initializing the LastSentState when spawning the NetworkTransform
LPLafontaineB Aug 4, 2022
e9fe769
updating changelog
LPLafontaineB Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
- Fixed NetworkLists not populating on client. NetworkList now uses the most recent list as opposed to the list at the end of previous frame, when sending full updates to dynamically spawned NetworkObject. The difference in behaviour is required as scene management spawns those objects at a different time in the frame, relative to updates. (#2062)
- Fixed NetworkList Value event on the server. PreviousValue is now set correctly when a new value is set through property setter. (#2067)
- Fixed NetworkList issue that showed when inserting at the very end of a NetworkList (#2099)
- Fixed NetworkTransform LastSentState not initialized at time of spawning. (#2106)

## [1.0.0] - 2022-06-27

Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Components/NetworkTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ public override void OnNetworkSpawn()
{
TryCommitTransformToServer(m_Transform, m_CachedNetworkManager.LocalTime.Time);
}
m_LocalAuthoritativeNetworkState = m_ReplicatedNetworkState.Value;
m_LastSentState = m_LocalAuthoritativeNetworkState = m_ReplicatedNetworkState.Value;
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into this issue in #2102 since there are some adjustments that could fix the issue you might be experiencing with client-side authority. m_LastSentState should be only set by the authority as that is all it is used for, and this change will set it on both non-authoritative and authoritative (although setting it on the non-authoritative side shouldn't have any real impact to non-authoritative instances).


// crucial we do this to reset the interpolators so that recycled objects when using a pool will
// not have leftover interpolator state from the previous object
Expand Down