fix: Remove "Script" fields from Netcode components in the inspector [MTT-2947]#2172
Merged
ShadauxCat merged 23 commits intodevelopfrom Sep 22, 2022
Merged
fix: Remove "Script" fields from Netcode components in the inspector [MTT-2947]#2172ShadauxCat merged 23 commits intodevelopfrom
ShadauxCat merged 23 commits intodevelopfrom
Conversation
0xFA11
approved these changes
Sep 7, 2022
ShadauxCat
commented
Sep 7, 2022
| else | ||
| { | ||
| base.OnInspectorGUI(); | ||
| EditorGUI.BeginChangeCheck(); |
Collaborator
Author
There was a problem hiding this comment.
Duplicated code... apparently one cannot add a class in between NetworkObjectEditor and Unity.Editor in the hierarchy without triggering a "public api change" error in the validator, so instead of being able to reuse this code, I have to copy/paste it...
That's pretty silly IMO.
JesseOlmer
reviewed
Sep 22, 2022
JesseOlmer
reviewed
Sep 22, 2022
JesseOlmer
reviewed
Sep 22, 2022
JesseOlmer
approved these changes
Sep 22, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…[MTT-2947] (Unity-Technologies#2172) * fix: Remove "Script" fields from Netcode components in the inspector * Standards * standards again * Fix compile errors in minimalproject * Whoops, those version defines were for the runtime, had to add them to editor too. * validator...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing and Documentation