Skip to content

chore: NGO 2.0.0-exp.4 merge back to develop NGO 2.0.0#2940

Merged
NoelStephensUnity merged 8 commits intodevelop-2.0.0from
chore/release-2.0.0-exp.4-merge-develop-2.0.0
May 31, 2024
Merged

chore: NGO 2.0.0-exp.4 merge back to develop NGO 2.0.0#2940
NoelStephensUnity merged 8 commits intodevelop-2.0.0from
chore/release-2.0.0-exp.4-merge-develop-2.0.0

Conversation

@fluong6
Copy link
Copy Markdown
Collaborator

@fluong6 fluong6 commented May 31, 2024

NGO 2.0.0-exp.4 merge back to develop NGO 2.0.0

Changelog

Testing and Documentation

  • Includes unit tests.
  • Includes integration tests.

NoelStephensUnity and others added 7 commits May 17, 2024 16:31
…DK package (#2875)

* update

Renaming Session Mode to Network Topology.
This includes any related properties or XML API documentation references.

Adding package dependent conditional define MULTIPLAYER_SDK_INSTALLED that is defined when the com.unity.services.multiplayer package is installed to the editor assembly definition file.

This removes the custom property drawer since it appears the default enum flag drawer visual bug is resolved in Unity 6.

incrementing the version change
* feat: expose the UTP connect payload

* pass accept payload

* fix formatting

* make Connect and m_Driver protected

* remove payload output
* feat: enum ordered message versioning  (#2929)

* chore: migrate tests from public to internal (#2930)

* update

Added the MessageTypeDefines ordering class that orders messages based on the NetworkMessageType.
Use tick offset.
Change the ticks ago based on whether DAHost or CMBService.
Changing all test public api to internal
Adding FixedJoint attach and detach methods to NetworkRigidbodyBase.

* test

Fixing issue with tests using their own message provider.
Fixing a few more tests that don't need the message ordering or count verification stuff to be running.
Removed the message ordering related tests since this it was no longer needed.


---------

Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>

* update

Migrated non-authority NetworkTransform updates to the pre late update to more align with how it is handled in v1.x.
Added NetworkRigidbodyBase reference to NetworkObject.
For now, added the ability to add a fixed joint when parenting two NetworkObjects with NetworkTransforms and NetworkRigidbodies that both have UseRigidBodyForMotion set to true (i.e. Rigidbody has no concept of "local space" motion).

* update

Change the FixedJoint approach so it does not require parenting.
The "parent" rigid body now updates its children in NetworkTransform when the "parent's" state is updated in order to keep both parent and children state updates synchronized on the same network tick.
Added NetworkObject.CurrentParent that is set when a NetworkObject is parented.
NetworkObject.NetworkTransform is now NetworkObject.NetworkTransforms (a single NetworkObject can have many NetworkTransforms).
NetworkObject.NetworkRigidbodybase is now NetworkObject.NetworkRigidbodies (a single NetworkObject can have many NetworkRigidbodybase components).

* fix

Adding COM_UNITY_MODULES_PHYSICS wrappers around NetworkObject.NetworkRigidbodies.

* fix

wrapping some physics dependent properties in #if COM_UNITY_MODULES_PHYSICS.

* fix

Last missed NetworkRigidbodies needed wrapping in #if COM_UNITY_MODULES_PHYSICS

* fix

Only invoke DetachFromFixedJoint if HasAuthority is true during despawn.

* fix

Fixing issue where NetworkTransforms updated during FixedUpdate can have a render time that is slightly earlier than the start time. The delta between the two is typically in the nano to pico seconds range.

This first pass approach to resolve this issue is to just cast the two double properties to floats prior to subtracting one from the other in order to reduce that level of granularity of the delta between the two.

---------

Co-authored-by: Frank Luong <100299641+fluong6@users.noreply.github.com>
adding release version and date to changelog
* updating changelog

* bumping ngo version in package json
@fluong6 fluong6 requested review from a team, chrispope and miniwolf as code owners May 31, 2024 18:30
@fluong6 fluong6 requested a review from NoelStephensUnity May 31, 2024 18:30
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I need to resolve some conflicts...

@NoelStephensUnity NoelStephensUnity self-requested a review May 31, 2024 18:36
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now looks good. 👍

@NoelStephensUnity NoelStephensUnity merged commit 3f59dff into develop-2.0.0 May 31, 2024
@NoelStephensUnity NoelStephensUnity deleted the chore/release-2.0.0-exp.4-merge-develop-2.0.0 branch May 31, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants