fix: notauthority da mode urpc sending to self#3000
Merged
NoelStephensUnity merged 6 commits intodevelop-2.0.0from Aug 6, 2024
Merged
fix: notauthority da mode urpc sending to self#3000NoelStephensUnity merged 6 commits intodevelop-2.0.0from
NoelStephensUnity merged 6 commits intodevelop-2.0.0from
Conversation
NoelStephensUnity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This incudes some universal RPC fixes.
Changelog
NotAuthorityTargetwould include the service observer in the list of targets to send the RPC to as opposed to excluding the service observer as it should.ProxyRpcTargetGroupcould attempt to send a message if there were no targets to send to.Testing and Documentation
RpcProxyMessageTesting.