Skip to content

chore: EntityId update for UnityTransport and MP Tools #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 2, 2025
Merged

chore: EntityId update for UnityTransport and MP Tools #3804

merged 6 commits into from
Dec 2, 2025
+10 −30

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Dec 1, 2025 •
edited
Loading

Purpose of this PR

This resolves the circular package/CI vetting process where MP tools required a change on the NGO side but NGO required the change already be applied to pass our standards/vetting checks that includes validating the most current MP tools package compiles with NGO.

Jira ticket

TBD (WIP)

Changelog

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done
    • Refer to PR-757 as to testing instructions.

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No backport is required since the EntityId update is applied in a version of Unity beyond that supported by NGO v1.x.

@NoelStephensUnity
update
80b0c3c 
Initial approach to resolve the circular dependency will be to use two unique defines created by both packages.
NGO will use the assembly version define MP_TOOLS_2_2_8_OR_HIGHER.
MP Tools will use the assembly version define NGO_2_8_0_OR_HIGHER.
@NoelStephensUnity
style
e761873 
whitespace adjustments
@NoelStephensUnity
update
3b1500f 
Simplifying this a bit as it is only used for testing purposes?
@cla-assistant-unity
Copy link

cla-assistant-unity bot commented Dec 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@NoelStephensUnity
update
8c1b6fc 
Removing this version define as it is no longer needed.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review December 1, 2025 23:58
@NoelStephensUnity NoelStephensUnity requested review from a team and EmandM as code owners December 1, 2025 23:58
EmandM
EmandM approved these changes Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@NoelStephensUnity NoelStephensUnity merged commit 2cca57e into develop-2.0.0 Dec 2, 2025
23 of 25 checks passed
@NoelStephensUnity NoelStephensUnity deleted the chore/entityid-update-unitytransport-initialized-disposed-actions branch December 2, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmandM EmandM EmandM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoelStephensUnity @EmandM