feat: Make NetworkTransport update methods public#3890
Merged
simon-lemay-unity merged 2 commits intodevelop-2.0.0from Mar 6, 2026
Merged
feat: Make NetworkTransport update methods public#3890simon-lemay-unity merged 2 commits intodevelop-2.0.0from
simon-lemay-unity merged 2 commits intodevelop-2.0.0from
Conversation
simon-lemay-unity
requested review from
a team,
EmandM and
NoelStephensUnity
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR makes the
EarlyUpdateandPostLateUpdatemethods ofNetworkTransportpublic. To be able to reuse NGO transports elsewhere, one needs access to those since that might be where most of the work is happening. (It's actually not so much the case for most of the community transports that rely mostly on regularUpdateto work, but still better to do things right.)The alternative would be giving internal access to the assembly reusing NGO transports. I don't have any strong opinion regarding which option is preferable. If you prefer internal access, I'll submit a PR that does that instead.
Jira ticket
None (yet).
Changelog
NetworkTransport.EarlyUpdateandNetworkTransport.PostLateUpdateare now public. For the vast majority of users, there's really no point in ever calling those methods directly (theNetworkManagerhandles it). It's only useful if wrapping transports outside of NGO.Documentation
Testing & QA
No need for testing.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Backports
N/A