Removed randomization tooling from the experimental namespace #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| using System; | ||
|
|
||
| namespace UnityEngine.Experimental.Perception.Randomization.Parameters | ||
| namespace UnityEngine.Perception.Randomization.Parameters |
Contributor
There was a problem hiding this comment.
Since there are many users of these APIs now, we should add [MovedFrom] decorations to the public types so that the script updater will automatically update users' code when they update to the latest package. For more, see https://confluence.unity3d.com/display/DEV/Move+type+to+another+namespace
Contributor
Author
There was a problem hiding this comment.
Cool! I've added this attribute to all our public API's.
sleal-unity
requested review from
JonathanHUnity
and removed request for
mkamalza
JonathanHUnity
approved these changes
Feb 1, 2021
eugeneteoh
pushed a commit
to eugeneteoh/com.eugeneteoh.perception
that referenced
this pull request
Apr 29, 2023
…Technologies#177) * removed randomization tooling from the experimental namespace * removed experimental namespace from randomization docs * removed vestigial precompiled references from asmdefs * added note to parameters doc * added helpful link inside parameters doc * fixed script name * added MovedFrom attribute to randomization APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer Review Information:
This PR removes the randomization tooling from the experimental namespace.
Note: I noticed that we include some references to assemblies that are no longer present in the perception package (PathCreator and QuickGraph) so I used this PR as an opportunity to remove them. I also sorted the order of the existing asmdef references while playing with Rider's "Sort Lines" code editing feature.
Editor / Package versioning:
Editor Version Target: 2019.4
Checklist