Skip to content

Conversation

@StevenBorkman
Copy link
Contributor

A quick fix for an index out of bounds error that could occur if a keypoint template file was not set up properly

Peer Review Information:

Information on any code, feature, documentation changes here

Editor / Package versioning:

Editor Version Target (i.e. 19.3, 20.1): 2019.3

Dev Testing:

Tests Added:

Core Scenario Tested:

At Risk Areas:

Notes + Expectations:

Checklist

  • - Updated docs
  • - Updated changelog

This error could occur when a template has a skeleton referencing joints that are not present in template
Copy link
Contributor

@JonathanHUnity JonathanHUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be awhile to write a test for this. Also, is there any impact on the json dataset with this setup?

@StevenBorkman
Copy link
Contributor Author

Should be awhile to write a test for this. Also, is there any impact on the json dataset with this setup?

This will not impact json file format

@JonathanHUnity
Copy link
Contributor

Sorry, I meant it would be good to add a test. What is the dataset output with one of these non matching joint labels?

@StevenBorkman
Copy link
Contributor Author

Sorry, I meant it would be good to add a test. What is the dataset output with one of these non matching joint labels?

So this is really only for visualization, the fix is in our visualization code. Our keypoint labeler does not care or really even know about the skeletal connections. A user who ingests our template file would have to handle this themselves, unless we were to write some sort of template validation tool

@StevenBorkman StevenBorkman merged commit 0532e91 into master Mar 10, 2021
@StevenBorkman StevenBorkman deleted the joint_out_of_bounds_fix branch March 10, 2021 23:55
eugeneteoh pushed a commit to eugeneteoh/com.eugeneteoh.perception that referenced this pull request Apr 29, 2023
…es#236)

This error could occur when a template has a skeleton referencing joints that are not present in template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants