Keypoint self occlusion #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference to the keypoint label config
… properly supporting player builds
…ect, but catches a few edge cases for now. Should migrate to doing all checks in shader at some point
com.unity.perception/Runtime/GroundTruth/Labelers/KeypointOcclusionOverrides.cs
Outdated
Show resolved
Hide resolved
JonathanHUnity
suggested changes
Jul 30, 2021
Contributor
JonathanHUnity
left a comment
JonathanHUnity
left a comment
There was a problem hiding this comment.
Just a couple of notes on the docs and the new class.
com.unity.perception/Documentation~/GroundTruth/KeypointLabeler.md
Outdated
Show resolved
Hide resolved
com.unity.perception/Documentation~/GroundTruth/KeypointLabeler.md
Outdated
Show resolved
Hide resolved
com.unity.perception/Runtime/GroundTruth/Labelers/KeypointLabeler.cs
Outdated
Show resolved
Hide resolved
…nity-Technologies/com.unity.perception into keypoint_self_occlusion_2020_3
JonathanHUnity
approved these changes
Sep 14, 2021
eugeneteoh
pushed a commit
to eugeneteoh/com.eugeneteoh.perception
that referenced
this pull request
Apr 29, 2023
* WIP self-occlusion checks. * More updates for self-occlusion * Almost working using compute shaders. Need to switch to regular rendering now. * Kind of working! * Ok, officially working now * Adding some tests for self-occlusion. Some fixes in KeypointLabeler * Fix issues with orthographic views and points close to far plane * Fixing remainder of tests. * Removing comments * Fixing issues in URP with orthographic view * Updating JointLabel * Updating JointLabel to include self-occlusion distance and drop the reference to the keypoint label config * Adding gizmos for keypoints * Adding and fixing remainder of tests. * Fixing various bugs in keypoint self occlusion, including (hopefully) properly supporting player builds * Fixing issues with large numbers of keypoints. * Fixing issue with resizing buffers * Add search for non-background pixel to keypoint depth check. Not perfect, but catches a few edge cases for now. Should migrate to doing all checks in shader at some point * Apply object scale even when using the global occlusion distance. * Make scaling of self-occlusion distance apply in every scenario * Fix joint scale * Moving self occlusion distance to the KeypointTemplate * Model based occludder distance overrides * Code cleaned up and commented * Tests for self-occlusion scalar value * Updated changelog file * Updated class documentation * Updates to documentation * Removed added, but unneeded, import * Mostly updated comments * Adding some comments to the depth check shader * Fixing test compile error and mistake in RenderTextureReader * Fixes for PR comments * Fix for shader to work properly in HDRP/URP * Another attempt to fix shaders for URP & HDRP * Tests are passing locally right now * Setting hdrp enabled disabled again * Another attempt * Another try to get these shaders to compile correctly * Magic test fix attempt * Incorporating mohsen's test fix * Update to fix compile error * One more attempt at fixing the keypoint shader * Attempt moving to newer unity version * Upgrade projects to 2020.3.16f1. * Updating shader to use PackageRequirements * Fixing package name * Updating to 2020.3.16 * Fixing keypoint depth issues on Linux * More project updated for 2020.3 and fixing tests. * Changing minimum version to 2020.3 * Cleaning up commented out code Co-authored-by: Jon Hogins <jonathanh@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer Review Information
Review for keypoint self occlusion.
Editor / Package versioning:
Editor Version Target: 2019.4
Dev Testing:
Tests Added:
Yes
Core Scenario Tested:
At Risk Areas:
Checklist