Fixing PBShape export using FBX Exporter #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-
suggested changes
May 19, 2021
Addons/Fbx.cs
Outdated
|
|
||
| var getMeshForComponent = FbxExporterAssembly.GetTypes() | ||
| .Where(t => t.BaseType == typeof(MulticastDelegate) && t.Name.StartsWith("GetMeshForComponent")) | ||
| .First(t => t.ContainsGenericParameters); |
Contributor
There was a problem hiding this comment.
We should replace the reflection here with an optional dependency on FBX Exporter
| if (component != null) | ||
| Object.DestroyImmediate(component); | ||
| // probuilder can't handle mesh assets that may be externally reloaded, just strip pb stuff for now. | ||
| StripProBuilderScripts.DoStrip(pmesh); |
karl-
approved these changes
May 19, 2021
JoelFortin
approved these changes
Jun 2, 2021
Contributor
JoelFortin
left a comment
JoelFortin
left a comment
There was a problem hiding this comment.
LGTM. Tried Export and Convert.
Also note for @vkovec, the warning we get about the temp meta file that needs to be deleted is logged right ?
modrimkus
approved these changes
Jun 8, 2021
Contributor
modrimkus
left a comment
modrimkus
left a comment
There was a problem hiding this comment.
Compared behaviour before/after fix - lgtm.
Contributor
|
@JoelFortin Yes I don't think the warning was specific to Probuilder, we have made a fix for the next release |
vkovec
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixing Probuilder mesh throwing errors with FBX Exporter due to the presence of ProBuilderShape that was not removed.
The PR calls the
StripProBuilderScriptsclass now for more consistency and the code is now also aware of the difference between "FBX Export" that does not replace the PB Object and "Convert to prefab" that creates a prefab, strips PB objects and replace the object in the scene.Links
Fogbugz: https://fogbugz.unity3d.com/f/cases/1334017/
Comments to Reviewers
[List known issues, planned work, provide any extra context for your code.]