Skip to content

Repository - Hide tools folder#654

Merged
thomas-tu merged 7 commits intomasterfrom
hide-tools-folder
Feb 25, 2026
Merged

Repository - Hide tools folder#654
thomas-tu merged 7 commits intomasterfrom
hide-tools-folder

Conversation

@thomas-tu
Copy link
Copy Markdown
Collaborator

Purpose of this PR

Hide the Tools/ folder so it doesn't get imported when we work with a local copy of the repository.

@u-pr
Copy link
Copy Markdown

u-pr Bot commented Feb 24, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR is extremely small, containing only simple path updates in two configuration files.
🏅 Score: 75

The PR correctly updates the gitignore file, but introduces a likely typo in the `.npmignore` file which will fail to ignore the renamed folder.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Incorrect Path Pattern

The paths ./Tools/ and ./Tools.meta refer to a directory and file named Tools in the current directory. They do not match a directory named .Tools. To correctly ignore the renamed .Tools folder, these should be changed to /.Tools/ and /.Tools.meta (or .Tools/ and .Tools.meta).

./Tools/
./Tools.meta
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

@u-pr
Copy link
Copy Markdown

u-pr Bot commented Feb 24, 2026

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix typo in ignored folder name

It appears there is a typo in the ignore paths. To properly target the newly renamed
.Tools folder at the root, the paths should be /.Tools/ and /.Tools.meta instead of
./Tools/ and ./Tools.meta.

.npmignore [38-39]

-./Tools/
-./Tools.meta
+/.Tools/
+/.Tools.meta
Suggestion importance[1-10]: 7

__

Why: The PR renames the Tools folder to .Tools in .gitignore, but introduces a typo in .npmignore by using ./Tools/ instead of properly targeting the new .Tools directory. This corrects the typo and ensures the directory is properly ignored by npm.

Medium
  • More suggestions

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

@codecov-github-com
Copy link
Copy Markdown

codecov-github-com Bot commented Feb 24, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files         277      277           
  Lines       34909    34909           
=======================================
  Hits        12588    12588           
  Misses      22321    22321           
Flag Coverage Δ
probuilder_MacOS_6000.0 34.58% <ø> (ø)
probuilder_MacOS_6000.3 34.58% <ø> (ø)
probuilder_MacOS_6000.4 34.58% <ø> (+<0.01%) ⬆️
probuilder_MacOS_6000.5 34.57% <ø> (ø)
probuilder_MacOS_6000.6 34.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-tu thomas-tu merged commit 0ece037 into master Feb 25, 2026
13 checks passed
@thomas-tu thomas-tu deleted the hide-tools-folder branch February 25, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants