GoQLSearchProvider compiler define enables incorrect namespace for 2020.3

[MostHated]

Hey there,
The GoQL Editor ASMDEF define 'AT_USE_QUICKSEARCH' is used within GoQLSearchProvider.cs, but the define itself is set to enable the incorrect using statement.

#if AT_USE_QUICKSEARCH || UNITY_2020_3
using Unity.QuickSearch;
#else //newer than 2021.2
using UnityEditor.Search;
#endif

Though, when using Unity 2020.3 the namespace of Unity.QuickSearch does not exist. The QuickSearch ASMDEF is named "com.unity.quicksearch", but that is not the actual namespace used within the QuickSearch code.

Errors

[CompilerError] The type or namespace name 'QuickSearch' does not exist in the namespace 'Unity' (are you missing an assembly reference?)
Compiler Error at Library/PackageCache/com.unity.selection-groups@0.7.2-preview/GoQL/Editor/GoQLSearchProvider.cs:15 column 13
14:   #if AT_USE_QUICKSEARCH 
-->15:   using Unity.QuickSearch;
16:   #else //newer than 2021.2
17:   using UnityEditor.Search;

Editor Assembly

Runtime Assembly

[sindharta]

#if AT_USE_QUICKSEARCH || UNITY_2020_3

This line looks wrong. Are you sure you are using com.unity.selection-groups@0.7.2-preview ?
This is GoQLSearchProvider.cs for 0.7.2-preview. (renamed the extension to txt so that I could upload it here)
GoQLSearchProvider.txt

[MostHated]

You are right about that. Now that I think about it, I might have added that || 2020.3 part when diagnosing the issue originally, and I just ended up commenting out that part entirely. That said, the underlying issue is the same, with or without that part.

This is a fresh 2020.3 project with only quicksearch and selection groups added to project, which gives the original error message I mentioned above.

I have not checked using QuickSearch v2.x, but perhaps the issue lies in a difference between QuickSearch v2 and v3. As of now, everything that I currently use in projects (packages and 3rd party assets) that requires QuickSearch uses v3. I will try and test it out if I get a chance, but I believe that if something along the lines of [3,1] is used in the version define constraints, it may fix it. Just to test (not sure what the constraint should actually be), I put in [3,1] and it resolved the issue for me as seen in the last image. Not to say that it is the correct resolution, but does provide a possibility.

[sindharta]

I have not checked using QuickSearch v2.x, but perhaps the issue lies in a difference between QuickSearch v2 and v3

Ah, yes, I think this is correct.
But how did you add QuickSearch v3 in Unity 2020.3.x ?

This is what appears in my PackageManager on a fresh Unity 2020.3.32f1 project, and I don't see QuickSearch v3 there.

Did you add it manually by typing selecting "add package from Git URL" and typing com.unity.quicksearch@3.0.0-preview.23, or perhaps modifying manifest.json directly ?

[sindharta]

Related PR: #247

[MostHated]

Yeah, I usually manage my packages manually through the manifest. I had came across it originally here: https://docs.unity3d.com/Packages/com.unity.quicksearch@3.0/manual/index.html and had it added to a few of my projects already.

But then I started using a newer asset (https://assetstore.unity.com/packages/tools/utilities/smart-library-200724) which has a requirement for QuickSearch v3 (seen at the bottom of the listing), so I had installed it in most of my projects now.

[sindharta]

Fix released in 0.7.4-preview. Please check

[MostHated]

Looks like everything is good now. I do appreciate it. 👍