feat: adding player names#41
Merged
Merged
Conversation
pierredalaya
suggested changes
Apr 14, 2023
| "com.unity.2d.sprite": "1.0.0", | ||
| "com.unity.ide.rider": "3.0.18", | ||
| "com.unity.services.authentication": "2.5.0-pre.3", | ||
| "com.unity.services.friends": "0.2.0-preview.9", |
Contributor
There was a problem hiding this comment.
Is this the latest public version of the friends SDK?
Contributor
Author
There was a problem hiding this comment.
It's the minimum value required for player names, so I believe so. I'll double check.
Contributor
Author
There was a problem hiding this comment.
Oh sorry, I thought you said auth SDK. As far as I know this is the most recent friends package, yes.
Contributor
|
Should this PR also not contain the ability to add friend by name ? |
pierredalaya
approved these changes
Apr 24, 2023
pierredalaya
added a commit
that referenced
this pull request
Apr 24, 2023
commit a22b0d1 Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 10:59:47 2023 -0400 Squashed commit of the following: release 1.0.1 commit 703081d Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 10:59:04 2023 -0400 changelog + project version commit d0c0a1a Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 10:49:51 2023 -0400 ugui pass commit afe9172 Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 10:06:53 2023 -0400 ugui tweaks commit 9de4756 Merge: 9e09bce 9de6109 Author: pierredalaya <112493809+pierredalaya@users.noreply.github.com> Date: Mon Apr 24 09:57:19 2023 -0400 Merge pull request #41 from Unity-Technologies/feat/player-names feat: adding player names commit 9de6109 Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 09:54:06 2023 -0400 uigui tweaks commit eb18bc6 Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 09:48:44 2023 -0400 add comment commit 48a3793 Author: Pierre Dalaya <pierre.dalaya@unity3d.com> Date: Mon Apr 24 09:41:30 2023 -0400 fixed UITk scene commit b3fbe0d Author: Danny Lewis <nitomatik@gmail.com> Date: Fri Apr 21 13:33:13 2023 -0700 removing ID fields commit 132666d Author: Danny Lewis <nitomatik@gmail.com> Date: Tue Apr 18 13:18:22 2023 -0700 removing asset changes commit bc4cfc5 Author: Danny Lewis <nitomatik@gmail.com> Date: Thu Apr 13 11:34:26 2023 -0700 adding player names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to add player names from the player names service. Does away with
IPlayerProfileService.csandSampleProfileService.csas names are automatically returned in the requests to the Friends service and one's own name is grabbed from the Auth service now.Additionally, the ID field has been removed and the "Add Friend" menu now adds by name rather than ID. See below for what the UI looks like in UGUI and UI Toolkit.
UGUI
Local player view
Add friend view
UI Toolkit
Local player view
Add friend view