[REQUEST] Setting Video Encoder Framerate

[keepingitneil]

Didn't see a ticket for this but I noticed in the docs that maxFramerate on the encoder is not supported.

At the very least it would be nice be able to set an ideal framerate during webrtc initialize.

At most, it would be cool to be able to tell the encoder when a new frame has come in to prevent double frames or skipped frames on render textures when the framerate is intended to be lower than the game fps.

Is there any way to cap the framerate today?

[karasusan]

I fixed this issue a half year ago, it might be worked.
#183

I will add the sample to check this feature and fix the docs. Thank you for telling to me.

[keepingitneil]

Appreciate it, I have been trying to do something like this to try to get it to work:
if(parameters.encodings.Length > 0) { parameters.encodings[0].maxBitrate = (ulong?)bitrate; parameters.encodings[0].minBitrate = (ulong?)bitrate; parameters.encodings[0].maxFramerate = 30; transceiver.Sender.SetParameters(parameters); break; }

but it still goes far above 30 as confirmed by the RTC stats on the sending side and chrome://webrtc-internals on the receiving side

[karasusan]

OK, I will check the issue. Thanks.

[pilzinho]

Appreciate it, I have been trying to do something like this to try to get it to work:
if(parameters.encodings.Length > 0) { parameters.encodings[0].maxBitrate = (ulong?)bitrate; parameters.encodings[0].minBitrate = (ulong?)bitrate; parameters.encodings[0].maxFramerate = 30; transceiver.Sender.SetParameters(parameters); break; }

but it still goes far above 30 as confirmed by the RTC stats on the sending side and chrome://webrtc-internals on the receiving side

I have the same issue. Setting maxFramerate this way doesn't work for me. It will always encode in the FPS of the application which is typically 60fps what is very bad for performance especially when having multiple connections.

[karasusan]

@keepingitneil @pilzinho
I reproduced it but have currently not found the workaround for the issue.

[karasusan]

Related issue
#632

[karasusan]

@keepingitneil
You can test this fix on the develop branch. Thank you.