Enable HAVE_POLL on macOS#35
Merged
Merged
Conversation
our curl version disabled this due to bugs on old macOS versions, which we do not support in Unity anymore. This is fixed in upstream curl, but while we work on that we can enable it manually
aurimasc
approved these changes
Feb 3, 2026
aurimasc
left a comment
aurimasc
left a comment
There was a problem hiding this comment.
Look good to me, but looping in new owner of UnityWebRequest.
Petezah
approved these changes
Feb 9, 2026
Petezah
left a comment
Petezah
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the additional context also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our curl version disabled usage of
poll()on, due to bugs on old macOS versions (macOS 10.12), which we do not support in any stream of Unity we currently support.This is fixed in newer versions of macOS. See
CURL_CHECK_FUNC_POLLfor details.Also refer to curl#1057 for some historical context here.
NB: Upstream curl re-enables this, so we can do away with this and re-generate once we upgrade curl version.