Add support for TLS 1.3#36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for TLS 1.3 to our UnityTLS VTLS wrapper.
Note that these changes are not actually required to get TLS 1.3 working with
UnityWebRequest. Our wrapper defers to UnityTLS to get the default protocol versions (throughUNITYTLS_TLSCTX_PROTOCOLRANGE_DEFAULT) so if we update UnityTLS with TLS 1.3 support it will automatically be picked up here. The changes in this PR are only required if we want to explicitly tell Curl to use TLS 1.3, although I don't know if any of the ways to do so are actually exposed to users. Still, it's a good thing to be thorough and update Curl anyway.The diff in
unitytls.clooks huge because I normalized the line endings (for some reason the file was committed with CRLF but the rest of Curl uses LF only). Here are the changes to that file without the whitespace noise: