Backport fix for: Reverse deps with -sERROR_ON_UNDEFINED_SYMBOLS=0 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re#19352) The change to `test_only_force_stdlibs` was needed because the failure case is now a build time rather than runtime error. Using `-sWARN_ON_UNDEFINED_SYMBOLS=0` (which implicitly sets `ERROR_ON_UNDEFINED_SYMBOLS=0` too) cannot prevent/delay errors when certain types of symbols are missing. For example the linker will always error on missing data symbols. After this change the linker will also always error on missing revert dependencies (of which malloc is one in this test case). Fixes: emscripten-core#19234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the fix emscripten-core#19352 from emscripten-core to our version of emscripten. This is done to fix the Unity bug: UUM-74261
Description from the original PR: