Skip to content

Conversation

@dongruoping
Copy link
Contributor

remove wrong vis_encode_type config

@dongruoping dongruoping requested a review from chriselion July 26, 2019 18:48
@chriselion
Copy link
Contributor

Whoops, we fixed this on the release branch but didn't merge it to develop:
https://github.com/Unity-Technologies/ml-agents/pull/2330/files

You might want to make that change instead, otherwise there are going to be merge conflicts later.

@dongruoping
Copy link
Contributor Author

Whoops, we fixed this on the release branch but didn't merge it to develop:
https://github.com/Unity-Technologies/ml-agents/pull/2330/files

You might want to make that change instead, otherwise there are going to be merge conflicts later.

Fixed

Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chriselion
Copy link
Contributor

#2346 will also fix this

@ervteng
Copy link
Contributor

ervteng commented Jul 26, 2019

Don't merge this! We've merged the release fix back into develop to fix daily testing.

@dongruoping
Copy link
Contributor Author

Don't merge this! We've merged the release fix back into develop to fix daily testing.

Sure then I'll close this one.

@dongruoping dongruoping deleted the develop-resnet branch July 29, 2019 23:53
@dongruoping dongruoping restored the develop-resnet branch July 29, 2019 23:53
@dongruoping dongruoping deleted the develop-resnet branch July 30, 2019 21:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants