Curricula json fix #2627
Closed
Curricula json fix #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Hi @Vaspra |
Contributor
Author
|
Hi,
Thanks, this is my first contrib to anything that I don't own and I was
sure I did something wrong. Change away!
Best,
Doug Lawrence
…On Thu, 26 Sep 2019, 06:12 Chris Elion, ***@***.***> wrote:
Hi @Vaspra <https://github.com/Vaspra>
Hope you don't mind, I changed the target branch from master to develop.
I'll take a closer look tomorrow..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2627?email_source=notifications&email_token=AIBUEWV6QK3HZIDDKBT5JQLQLRAEPA5CNFSM4I2UG4BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UKB6A#issuecomment-535339256>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIBUEWTQVEL5H3JQ6HGLKB3QLRAEPANCNFSM4I2UG4BA>
.
|
chriselion
reviewed
Sep 26, 2019
| for curriculum_filename in os.listdir(curriculum_folder): | ||
| for curriculum_filename in\ | ||
| [fn for fn in os.listdir(curriculum_folder)\ | ||
| if not fn.endswith('.meta')]: |
Contributor
There was a problem hiding this comment.
How about just moving this check inside the loop, like
if curriculum_filename.endswith('.meta'):
continue?
chriselion
reviewed
Sep 26, 2019
Contributor
chriselion
left a comment
chriselion
left a comment
There was a problem hiding this comment.
Hi Doug,
Thanks for the submission. I left a comment; I think the check would be better in the loop.
We just turned on continuous integration (CircleCI) for forked pull requests like this one; I think next time you push it will run. The formatter (black) will definitely try to reformat that for loop anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue with
meta_curriculumattempting to generate curricula instances from Unity-madecurricula/MyThingLearning/MyThingLearning.json.metafiles. Obviously the meta files are not intended to be used as .json sources.The change simply excludes filenames ending in
.meta.