Modified meta_curriculum JSON reading loop to only deal with .json #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this the reason that caused this ? |
Contributor
Author
|
@DanAmador Yes it is, I had not seen this issue. I was wracking my head with it last week but realised it was simply trying to json.load the Unity .meta files. With this modification mine works fine where it previously did not. |
This was referenced Oct 1, 2019
chriselion
reviewed
Oct 1, 2019
|
|
||
| try: | ||
| for curriculum_filename in os.listdir(curriculum_folder): | ||
|
|
Contributor
There was a problem hiding this comment.
I think black (the style checker) is complaining about whitespace on this line.
chriselion
approved these changes
Oct 1, 2019
Contributor
chriselion
left a comment
chriselion
left a comment
There was a problem hiding this comment.
Looks good! Thanks for making this change.
Contributor
|
As a side note, #2601 hopefully made these issues easier to debug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2627
This is a bit cleaner!
Causes a
continuein curriculum generation when the source file is not an expected JSON file.