[life improvement] Moving Python files around #4531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `trainer` folder
chriselion
reviewed
Oct 1, 2020
chriselion
reviewed
Oct 1, 2020
| @@ -1 +1,2 @@ | |||
| from mlagents.trainers.trainer.trainer import Trainer # noqa | |||
| from mlagents.trainers.trainer.trainer_factory import TrainerFactory # noqa | |||
Contributor
There was a problem hiding this comment.
I'd rather remove this and keep the import explicit:
from mlagents.trainers.trainer.trainer_factory import TrainerFactory
Contributor
There was a problem hiding this comment.
Actually, why not just keep trainer_factory.py in the trainers directory?
Contributor
Author
There was a problem hiding this comment.
I am trying to compartmentalize. The TrainerFactory creates a Trainer, so I think it makes sense to have it in the trainers.trainer folder.
The only reason I put the import inside the init is because mlagents.trainers.trainer.trainer_factory is 3 times trainer :)
Contributor
|
Please update the migration guide, since anyone who's calling these in their code will need to update it. |
chriselion
approved these changes
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Moved components to the tf folder and moved the TrainerFactory to the
trainerfolderUseful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments