Fix update il2cpp deps #2162
Merged
Fix update il2cpp deps #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Publish to Stevedore to use new upload executable Update token key used for prtools Adding generate_artifactid script to create the file PRTools is looking for. artifactid file is now in collectedbuilds
UnityAlex
force-pushed
the
fix-update-il2cpp-deps
branch
from
f38410b to
9cb1664
Compare
mostynb
reviewed
Jun 30, 2025
Comment on lines
+12
to
+16
| - curl -sSo StevedoreUpload "$STEVEDORE_UPLOAD_TOOL_LINUX_X64_URL" | ||
| - chmod +x StevedoreUpload | ||
| - mv collectedbuilds/builds.tar.zst collectedbuilds/MonoBleedingEdge.tar.zst | ||
| - .yamato/scripts/generate_artifactid.sh collectedbuilds/MonoBleedingEdge.tar.zst | ||
| - ./StevedoreUpload --repo=unity-internal --version-len=8 --version="$GIT_REVISION" collectedbuilds/MonoBleedingEdge.tar.zst |
There was a problem hiding this comment.
I think you could do all this in a compound block without the need for the generate_artifactid.sh script, eg:
Suggested change
| - curl -sSo StevedoreUpload "$STEVEDORE_UPLOAD_TOOL_LINUX_X64_URL" | |
| - chmod +x StevedoreUpload | |
| - mv collectedbuilds/builds.tar.zst collectedbuilds/MonoBleedingEdge.tar.zst | |
| - .yamato/scripts/generate_artifactid.sh collectedbuilds/MonoBleedingEdge.tar.zst | |
| - ./StevedoreUpload --repo=unity-internal --version-len=8 --version="$GIT_REVISION" collectedbuilds/MonoBleedingEdge.tar.zst | |
| - |- | |
| set -euxo pipefail | |
| curl -sSo StevedoreUpload "$STEVEDORE_UPLOAD_TOOL_LINUX_X64_URL" | |
| chmod +x StevedoreUpload | |
| mv collectedbuilds/builds.tar.zst collectedbuilds/MonoBleedingEdge.tar.zst | |
| revision=$(git rev-parse --short HEAD) | |
| artifactsha=$(sha256sum $1 | cut -d " " -f1) | |
| echo "MonoBleedingEdge/${revision}_${artifactsha}.tar.zst\n" > collectedbuilds/artifactid.txt | |
| ./StevedoreUpload --repo=unity-internal --version="$revision" collectedbuilds/MonoBleedingEdge.tar.zst |
Collaborator
Author
There was a problem hiding this comment.
I didn't know about compound blocks! That's pretty neat. I still think I like having the logic off in a script to keep the yamato file less busy and a bit easier to read.
mostynb
approved these changes
Jun 30, 2025
mostynb
left a comment
mostynb
left a comment
There was a problem hiding this comment.
Up to you though. I think either way will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates buildscripts to have the ability to push the collated mono builds.tar.zsh to stevedore.
Reviewers: please consider these questions as well! ❤️