This repository was archived by the owner on Jan 9, 2023. It is now read-only.
[pr] Fix Timestamp Comparison #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
These changes look good to me considering that you only have milliseconds for one of the timestamps. 👍
Was this helpful? Let us know!
| } | ||
|
|
||
| if (program.timestampCheck && stats.mtimeMs !== file.ts * 1000) { | ||
| if (program.timestampCheck && Math.trunc(stats.mtimeMs / 1000) !== file.ts) { |
There was a problem hiding this comment.
Good catch here, this change makes sense. Nice use of trunc instead of floor as well since this will always be positive, you get a slight performance boost. I assume that this wouldn't be run multiple times per seconds for the same file so we shouldn't need to worry about accidentally caching a changed file in the same second?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file.tsis in seconds, andstats.mtimeMsis in milliseconds. Comparing in milliseconds was not working, sincefile.tshas less significant digits.Rounding
stats.mtimeMsto seconds instead should fix this.