This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Read all relevant options from config file too #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Got the wrong bug-id in the original message - it fixes 43, not 41... |
|
Any way we can get this in? Not sure how to verify my current configuration is working or not |
Contributor
|
This is implemented in #65 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads port number, worker count and log-level from config too. Reverts to default values if they're not present.
Given the
--dump-configand--save-configmerely passes the raw text of the default configuration file through, I've added some commented-out values there.Fixes #43 and touches on #28.