#USDU-155 Create import/export helpers to clean the UsdMenu #237
Conversation
| namespace Unity.Formats.USD | ||
| { | ||
| public class UsdMenu : MonoBehaviour | ||
| public class UsdMenu |
There was a problem hiding this comment.
make the class static maybe ?
| #if UNITY_EDITOR | ||
| public static Scene InitForSave(string defaultName, string fileExtension = "usd,usda,usdc") | ||
| { | ||
| var filePath = EditorUtility.SaveFilePanel("Export USD File", "", defaultName, fileExtension); |
There was a problem hiding this comment.
I would split this function differently:
The only editor only function is EditorUtility.SaveFilePanel: add that in the editor assembly and keep the rest of of this function as a runtime function.
| { | ||
| Scene scene = null; | ||
|
|
||
| foreach (GameObject go in Selection.gameObjects) |
There was a problem hiding this comment.
Selection exists only in the editor. Make a function that exports a list of GOs and call that with the selection from the editor assembly.
| } | ||
| catch (SceneImporter.ImportException) | ||
| { | ||
| Object.DestroyImmediate(root); |
There was a problem hiding this comment.
Not sure if it makes a difference: in playmode you wanna call Destroy, and out of playmode DestroyImmediate. Make yourself an utility function that abstracts this.
| } | ||
|
|
||
| #if UNITY_EDITOR | ||
| public static void ImportAsPrefab(Scene scene) |
| } | ||
| } | ||
|
|
||
| public static void ImportAsTimelineClip(Scene scene) |
| /// </summary> | ||
| static string GetSelectedAssetPath() | ||
| { | ||
| Object[] selectedAsset = Selection.GetFiltered(typeof(Object), SelectionMode.Assets); |
There was a problem hiding this comment.
Think Selection is Editor only
judubu
force-pushed
the
import_helpers
branch
from
222b79c to
3cd29eb
Compare
mfe
left a comment
mfe
left a comment
There was a problem hiding this comment.
LGTM
Did some testing on 2020.2 (win), change looks indeed transparent.
judubu
changed the title
Purpose of this PR
Ticket/Jira #: https://jira.unity3d.com/browse/USDU-155
Preparatory work for the mesh import/conversion layer fixes.
UsdMenu used to contain a lot of import logic making it hard to reuse and test. All the logic has been moved to 2 new static classes ImportHelpers and ExportHelpers.
Testing
Functional Testing status:
Tried to cover 100% of the Import/ExportHelpers.
Performance Testing status:
N/A
Overall Product Risks
Complexity:
Low
Halo Effect:
Low
Additional information
Note to reviewers:
Reminder: