CMake use mono (USDU-160) #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clusty
approved these changes
Apr 19, 2021
Contributor
clusty
left a comment
clusty
left a comment
There was a problem hiding this comment.
Looks good (gibberish :) ):
Also fixes a bunch of build warnings for duplicated files Also fixes the Mono_PInvoke decoration script to prevent decorating multiple times.
Will work fine when the USD.NET.Unity move branch is merged
Building USD.NET with custom Mono is now optional. Default is still to use the version provided by Unity.
judubu
force-pushed
the
cmake_use_mono_USDU-160
branch
from
eb64e28 to
df4e211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #: https://jira.unity3d.com/browse/USDU-160
USD.NET can now be built on OSX and CMake looks for a Mono install as opposed to a Unity.
Fixes some gen type issue which was messing up bindings signatures tfor int64/uint64 types.
Bindings tests are now back as a CMake component but won't work until the USD.NET.Unity move PR lands (it fixes the tests by removing the Unity dependency)
Testing
Functional Testing status:
The package loads fine and all tests pass
Performance Testing status:
N/A
Overall Product Risks
Complexity:
Low
Halo Effect:
Low
Additional information
Note to reviewers: