Fix prefab reload in isolation (#USDU-128) #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clusty
approved these changes
May 18, 2021
thomas-tu
approved these changes
May 20, 2021
phocodes
approved these changes
May 27, 2021
cguer
approved these changes
Jun 2, 2021
Contributor
cguer
left a comment
cguer
left a comment
There was a problem hiding this comment.
QA approved 👍!
Everything looks good but should we (or is it possible to) add a unit test for this?
Tested on:
- 2021.2.0a17 (Windows only)
…rking in the active scene but not with prefabs.
judubu
force-pushed
the
bugfix/refresh_twice_in_prefab_stage
branch
from
f1512a1 to
851988b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #: https://jira.unity3d.com/browse/USDU-128
Payload loading rules were not respected in prefab isolation and were requiring to press "Reload" twice when changing the Payload Policy.
To do that the bindings have been updated to include the StageLoadRules (https://graphics.pixar.com/usd/docs/api/stage_load_rules_8h.html)
Testing
Functional Testing status:
Load the kitchen_set prefab, go in isolation, change the Payload Policy to LoadAll and press Reload should load the missing payloads.
Performance Testing status:
N/A
Overall Product Risks
Complexity:
Minimal
Halo Effect:
Minimal
Additional information
Note to reviewers:
The only functional change is in UsdAsset.
The other file manually modified is usd.i
Everything is SWIG generated
Reminder: