feat: testing guide, moderation authorization, non-blocking share fallback, and WCAG AA contrast - #214
Open
Ibinola wants to merge 1 commit into
Open
Conversation
…lback, and WCAG AA contrast Implement assigned issues for ibinola: - Add watch-mode & path pattern testing guide to CONTRIBUTING (UnityChainxx#93) - Enforce authorization checks in bulkModerateReviews (UnityChainxx#84) - Replace blocking alert with non-blocking feedback in ShareButton (UnityChainxx#73) - Improve text contrast ratio for WCAG AA compliance (UnityChainxx#79) Closes UnityChainxx#93 Closes UnityChainxx#84 Closes UnityChainxx#79 Closes UnityChainxx#73
|
@Ibinola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves all assigned issues for
ibinola:npm testruns Jest but no watch-mode guide in CONTRIBUTING #93): Added Testing Strategies section toCONTRIBUTING.mddocumenting Jest path pattern filtering and watch-mode execution.bulkUpdateReviewStatusesdoes not check per-item authorization, only bulk #84): Enforced authorization check inbulkModerateReviewsandmoderateReviewwithinmoderation.service.ts.ShareButtonfallback usesalert()which blocks the thread #73): Replacedalert()inShareButton.jsxwith a non-blocking temporary copied state and UI toast notification badge.bg-white/10andtext-gray-300likely fails WCAG AA #79): Adjusted contrast ratios on dark backgrounds to satisfy WCAG AA 4.5:1 minimum ratio.Closes #93
Closes #84
Closes #79
Closes #73