require ToS for requesting PI group membership in groups.php #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Terms of Service (ToS) acceptance requirement when requesting PI group membership. Users must now check a ToS checkbox before submitting their membership request.
Key changes:
- Added a required ToS checkbox with link in the PI membership request modal
- Implemented server-side validation to enforce ToS acceptance
- Updated functional tests to include the ToS parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webroot/panel/modal/new_pi.php | Added required ToS checkbox with link to terms of service |
| webroot/panel/groups.php | Added server-side validation to check ToS acceptance before processing request |
| test/functional/PIMemberRequestTest.php | Updated test helper to include ToS parameter in POST request |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-11-10.at.7.36.11.PM.mov