Skip to content

require ToS for requesting PI group membership in groups.php #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonLeary42 merged 4 commits into from
Nov 11, 2025
Merged

require ToS for requesting PI group membership in groups.php #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cedad81
require ToS for requesting PI group membership in groups.php
simonLeary42 Nov 11, 2025
b6fa308
missed one
simonLeary42 Nov 11, 2025
1618012
Update webroot/panel/modal/new_pi.php
simonLeary42 Nov 11, 2025
20af216
indentation
simonLeary42 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/functional/PIMemberRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ private function requestMembership(string $gid_or_mail)
http_post(__DIR__ . "/../../webroot/panel/groups.php", [
"form_type" => "addPIform",
"pi" => $gid_or_mail,
"tos" => "agree",
]);
}

Expand Down
1 change: 1 addition & 0 deletions test/functional/PiMemberApproveTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ private function requestJoinPI(string $gid)
http_post(__DIR__ . "/../../webroot/panel/groups.php", [
"form_type" => "addPIform",
"pi" => $gid,
"tos" => "agree",
]);
}

Expand Down
3 changes: 3 additions & 0 deletions webroot/panel/groups.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@

switch ($_POST["form_type"]) {
case "addPIform":
if (!isset($_POST["tos"]) || $_POST["tos"] != "agree") {
UnityHTTPD::badRequest("user did not agree to terms of service");
}
if ($pi_account->exists()) {
if ($pi_account->requestExists($USER)) {
array_push($modalErrors, "You've already requested this");
Expand Down
7 changes: 7 additions & 0 deletions webroot/panel/modal/new_pi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@
<input type="text" id="pi_search" name="pi" placeholder="Search PI by NetID" required>
<div class="searchWrapper" style="display: none;"></div>
</div>
<label>
<input type='checkbox' name='tos' value='agree' required>
I have read and accept the
<a href='<?php echo CONFIG["site"]["terms_of_service_url"]; ?>' target='_blank'>
Terms of Service
</a>.
</label>
<input type="submit" value="Send Request">
</form>

Expand Down