fix(rest/python): derive unsupported test version dynamically - #161
Merged
carolinerg1 merged 1 commit intoAug 4, 2026
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The unsupported-version integration test hard-coded 2026-04-09 and therefore depended on the discovery profile remaining at 2026-04-08. Once the profile version advanced, the request could be accepted and the test would fail even though version negotiation was correct. Derive the requested version as one day after app.version and use it in both the UCP-Agent header and expected error response. Tests: uv run --directory rest/python/server pytest -v
damaz91
added
the
status:needs-triage
quanwenshuang
force-pushed
the
fix/rest-python-unsupported-version-test-v2
branch
from
August 3, 2026 15:32
0555fc1 to
a1a4dfb
Compare
damaz91
added
status:under-review
and removed
status:needs-triage
damaz91
approved these changes
Aug 4, 2026
carolinerg1
self-requested a review
August 4, 2026 16:15
carolinerg1
approved these changes
Aug 4, 2026
carolinerg1
merged commit Aug 4, 2026
fd17e35
into
Universal-Commerce-Protocol:main
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.versioninstead of hard-coding a dateunsupported_versionconsistently in the request header and expected error responseTesting
uv run --directory rest/python/server pytest -v(20 passed)Known check
pre-commitreports E501 for the two lines containingunsupported_version; they remain unchanged apart from the requested variable rename