Fix Open Button

[Saira-A]

This corrects the open button png to the correct icon.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
universalviewer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 16, 2025 11:20am

[demiankatz]

@Saira-A, after thinking about it more, I think I understand the purpose of the settings now: the idea is that you activate this button and set a template pointing at your own instance of the UV. This way, if somebody else embeds your viewer, it has a link "home" to the full-page version. That's why it only displays in the iframe.

I think maybe we should put the iframe check back, but just be sure this is clearly explained in the documentation. In any case, fixing the icon is obviously a good idea, no matter what else we do.

I wonder if it might also be valuable to add a new setting called "simulateIframe" (or similar) that could be used for testing/debugging this -- it could just force isInIFrame to return true. Maybe that's not feasible, though -- I didn't look at the code, so I'm not sure if that function can possibly have access to configs. Maybe something to consider in future if it's not really practical today.

[demiankatz]

I've also added this to the community board "in testing" so we remember to discuss during stand-up. :-)

[Saira-A]

@Saira-A, after thinking about it more, I think I understand the purpose of the settings now: the idea is that you activate this button and set a template pointing at your own instance of the UV. This way, if somebody else embeds your viewer, it has a link "home" to the full-page version. That's why it only displays in the iframe.

I think maybe we should put the iframe check back, but just be sure this is clearly explained in the documentation. In any case, fixing the icon is obviously a good idea, no matter what else we do.

I wonder if it might also be valuable to add a new setting called "simulateIframe" (or similar) that could be used for testing/debugging this -- it could just force isInIFrame to return true. Maybe that's not feasible, though -- I didn't look at the code, so I'm not sure if that function can possibly have access to configs. Maybe something to consider in future if it's not really practical today.

Ah, that makes sense. I've put the check back so this PR just fixes the icon for now

[demiankatz]

Thanks, @Saira-A -- I'll approve, and we can merge on Monday if no one objects (and I can't imagine why they would). :-)

[Saira-A]

Thanks @demiankatz - I did also test setting the config to true and embedding the iframe into a html page and it does work as intended so I've updated the documentation to reflect this

[LanieOkorodudu]

Thanks, @Saira-A -- I'll approve, and we can merge on Monday if no one objects (and I can't imagine why they would). :-)

[LanieOkorodudu]

I agree with your suggestion, @demiankatz to add a simulateIframe option, especially for those who may not be familiar with creating an iframe manually. I created one myself and saved it as an HTML file to test on my end, but as you mentioned, it's definitely something we could consider adding in the future. This looks good to merge! thank you, @Saira-A and @demiankatz !