Stamp Windows FileVersion into the exe - #49
Merged
Conversation
xt had a Windows icon and manifest sitting untracked; this commits them and embeds VERSIONINFO the same way unpackerr does, using the x.y.z prefix of .Version plus REVISION so --nightly cannot fall back to a stale .RawVersion. No Darwin Info.plist: xt is a quill-notarized CLI, not an app bundle. Co-authored-by: Cursor <cursoragent@cursor.com>
The previous ico was Unpackerr's. This one is the circular paint-splatter XT mark from the repo wordmark, packed as 16–256 so Explorer stays sharp. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Windows-specific resources to the xt.exe build so Windows Explorer shows the expected icon/manifest metadata and (intended) version information in file properties.
Changes:
- Add a Windows manifest and documentation for the Windows icon assets.
- Add a GoReleaser pre-build hook to generate Windows
.sysoresource files viagoversioninfo. - Ignore generated
.sysoresource artifacts in Git.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| init/windows/README.md | Documents the Windows icon assets and how they’re embedded. |
| init/windows/manifest.xml | Adds an application manifest intended to be embedded into the Windows executable. |
| .goreleaser.yaml | Adds a goversioninfo hook to generate Windows resource .syso files and stamp version metadata. |
| .gitignore | Ignores generated Windows resource .syso files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xt has no Darwin app bundle (quill-notarized universal CLI + Homebrew cask of the binary), so there is no `CFBundleShortVersionString` to stamp.
Test plan
Made with Cursor