Skip to content

New Font#170

Closed
Oreig403 wants to merge 19 commits intoUpsilonNumworks:upsilon-devfrom
Oreig403:upsilon-dev
Closed

New Font#170
Oreig403 wants to merge 19 commits intoUpsilonNumworks:upsilon-devfrom
Oreig403:upsilon-dev

Conversation

@Oreig403
Copy link
Copy Markdown

For the years I've had my numworks I think one of the most horrible thing on it is the font.

Screenshot from 2022-02-27 17-33-28
Screenshot from 2022-02-27 17-33-58
Screenshot from 2022-02-27 17-32-33

@Yaya-Cout
Copy link
Copy Markdown
Member

Yaya-Cout commented Mar 1, 2022

Thank you for this pull request ! How do you build this (I have an error and the CI too) ?

Comment thread kandinsky/fonts/code_points.h
Comment thread kandinsky/fonts/code_points.h Outdated
Comment thread kandinsky/fonts/code_points.h Outdated
@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

This pull request was made on an old version of upsilon. I am fixing that

@Yaya-Cout
Copy link
Copy Markdown
Member

Thank you !

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

LargeFontExtended.ttf \
SmallFontExtended.ttf \
)
simple_kandinsky_src += $(addprefix kandinsky/fonts/, \
LargeFontSimple.ttf \
SmallFontSimple.ttf \
)

What are the Extended and Simple for?

@Yaya-Cout
Copy link
Copy Markdown
Member

Yaya-Cout commented Mar 2, 2022

It for the reader, to support the Greek's chars in LaTeX expressions

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

Ok, Thanks!

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

Thank you for this pull request ! How do you build this (I have an error and the CI too) ?

Fixed!

@Yaya-Cout
Copy link
Copy Markdown
Member

Yaya-Cout commented Mar 2, 2022

Thank you, but there is an LD error : undefined reference to KDFont::privateItalicFont'

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

oh ? I didn't get that. Will try to fix

Comment thread kandinsky/fonts/code_points.h Outdated
@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

All fixed

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

I forgot to import some files

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

Strange.. I have a working extension on local but the github version doesn't seem to work

@Yaya-Cout
Copy link
Copy Markdown
Member

Do you try make cleanall ? I will run the CI to help for debugging.

Comment thread apps/graph/list/list_controller.h Outdated
Co-authored-by: Yaya-Cout <67095734+Yaya-Cout@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2022

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813056 bytes 442316 bytes 226896 bytes 1776 bytes 228672 bytes 1257148 bytes
Head 811160 bytes 453636 bytes 226888 bytes 1776 bytes 228664 bytes 1266572 bytes
-1896 bytes +11320 bytes -8 bytes +0 bytes -8 bytes +9424 bytes
-0.2 % +2.6 % -0.0 % +0.0 % -0.0 % +0.7 %

@Yaya-Cout
Copy link
Copy Markdown
Member

Can you resolve conflicts ?

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

looks like it is working Thanks

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

I'll try

@Yaya-Cout
Copy link
Copy Markdown
Member

Thank you ! I just test, and I saw of the imaginary still broken…

@Oreig403
Copy link
Copy Markdown
Author

Oreig403 commented Mar 2, 2022

No I fixed that on my claculator maybe I didn't upload the final fonts?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2022

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813056 bytes 442316 bytes 226896 bytes 1776 bytes 228672 bytes 1257148 bytes
Head 813056 bytes 453980 bytes 226896 bytes 1776 bytes 228672 bytes 1268812 bytes
+0 bytes +11664 bytes +0 bytes +0 bytes +0 bytes +11664 bytes
+0.0 % +2.6 % +0.0 % +0.0 % +0.0 % +0.9 %

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2022

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813056 bytes 442316 bytes 226896 bytes 1776 bytes 228672 bytes 1257148 bytes
Head 813056 bytes 453980 bytes 226896 bytes 1776 bytes 228672 bytes 1268812 bytes
+0 bytes +11664 bytes +0 bytes +0 bytes +0 bytes +11664 bytes
+0.0 % +2.6 % +0.0 % +0.0 % +0.0 % +0.9 %

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2022

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813056 bytes 442316 bytes 226896 bytes 1776 bytes 228672 bytes 1257148 bytes
Head 813056 bytes 453972 bytes 226896 bytes 1776 bytes 228672 bytes 1268804 bytes
+0 bytes +11656 bytes +0 bytes +0 bytes +0 bytes +11656 bytes
+0.0 % +2.6 % +0.0 % +0.0 % +0.0 % +0.9 %

@darthnithin
Copy link
Copy Markdown

When can we expect this to be merged

@Oreig403
Copy link
Copy Markdown
Author

I need to work on it as the ci checks are not successful

@Oreig403
Copy link
Copy Markdown
Author

It actually depends on if someone wants a new font

@Oreig403
Copy link
Copy Markdown
Author

And if so what font?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants