Skip to content

[ ion ] XNT global improvement #157#171

Closed
devdl11 wants to merge 5 commits intoUpsilonNumworks:upsilon-devfrom
devdl11:upsilon-issue157
Closed

[ ion ] XNT global improvement #157#171
devdl11 wants to merge 5 commits intoUpsilonNumworks:upsilon-devfrom
devdl11:upsilon-issue157

Conversation

@devdl11
Copy link
Copy Markdown
Member

@devdl11 devdl11 commented Feb 28, 2022

Solving issue 157.

Some apps need to be fix in order to work properly with this improvement

Apps: Probability, Statistics, Regression
Cause: Text insertion inverted

@devdl11 devdl11 marked this pull request as draft February 28, 2022 12:46
@github-actions
Copy link
Copy Markdown

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813056 bytes 442316 bytes 226896 bytes 1776 bytes 228672 bytes 1257148 bytes
Head 812904 bytes 442062 bytes 226912 bytes 1776 bytes 228688 bytes 1256742 bytes
-152 bytes -254 bytes +16 bytes +0 bytes +16 bytes -406 bytes
-0.0 % -0.1 % +0.0 % +0.0 % +0.0 % -0.0 %

Comment thread ion/src/device/n0110/flash.ld Outdated
* Without an explicit linker script, the linker will produce a binary file that
* would not match some of our requirements (for example, we want the code to be
* written at a specific address (in Flash ROM) and the data at another. */
/* Linker script
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you indent all this file ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't see that ... my mistake 😅

@Yaya-Cout Yaya-Cout linked an issue Feb 28, 2022 that may be closed by this pull request
@devdl11 devdl11 marked this pull request as ready for review March 9, 2022 17:32
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2022

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813056 bytes 442316 bytes 226896 bytes 1776 bytes 228672 bytes 1257148 bytes
Head 813264 bytes 442139 bytes 226912 bytes 1776 bytes 228688 bytes 1257179 bytes
+208 bytes -177 bytes +16 bytes +0 bytes +16 bytes +31 bytes
+0.0 % -0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@devdl11 devdl11 changed the title Upsilon issue157 [ ion ] XNT global improvement #157 Mar 17, 2022
@Lauryy06
Copy link
Copy Markdown
Member

Lauryy06 commented Jul 6, 2022

Thanks for the pull request but I think that my implementation in 51a5f69 is more clean, especially because there is no "restart app" method.

@Lauryy06 Lauryy06 closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[x, n, t]

3 participants