[build] update apps_layout.csv from EPSILON_APPS flag in make command#341
Merged
Yaya-Cout merged 2 commits intoUpsilonNumworks:upsilon-devfrom Nov 5, 2025
Merged
Conversation
Author
|
I just renamed the branch |
|
Yaya-Cout
approved these changes
Nov 5, 2025
Member
Yaya-Cout
left a comment
Yaya-Cout
left a comment
There was a problem hiding this comment.
Seems fine, I would have added apps/home/apps_layout.csv to gitignore (as the file is now generated), but it's not a big deal (other files/folders should also be added there, so it can be done later)
Comment on lines
+21
to
+22
| line1 = 'Default,'+','.join(ordered)+'\n' | ||
| line2 = 'HidePython,'+','.join(ordered)+'\n' |
Member
There was a problem hiding this comment.
I would have preferred the last comma to be removed, but it's working anyway…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did it ! It's my first real modification of Upsilon (and of any c++ project) ! 🎉
I fixed a bug :
When you buid Upsilon changing the app order with the EPSILON_APPS flag, the layout stayed the old one, and the app you clicked on wasn't the shown one.
It's easier to understand with screenshots:
image
and when I click on it, it opens the python app !
image
To fix it, the apps_layout.csv is automaticly updated from the EPSILON_APPS flag in the make command.
The Default and HidePython layouts are both updated because of the same bug: the layout and the content of the home app isn't synchronized (pressing the graph icon doen't mean go to the graph icon, but go to the app n°x, which can be different from the graph app).