fix: align Toolkits header (scan all plugin src for Tailwind)#1162
Merged
Conversation
The Tailwind v4 @source globs only scanned plugin UI under plugins/*/src/react/**. The toolkits plugin keeps its UI directly in src/ (page.tsx, client.tsx), so those files were never scanned and any utility class used only there was dropped from the generated CSS. The Toolkits content header uses min-h-12 (used nowhere else), so it was never generated: the header lost its 48px floor and collapsed to ~36px while the h-12 sidebar header stayed 48px, leaving the two header bottom borders misaligned. min-h-36 and space-y-7 were dropped the same way (min-h-36 was only masked by an inline minHeight fallback on the card). Widen the glob to plugins/*/src/** so all plugin UI is scanned, regardless of whether it lives under src/react. Also covers the desktop-settings and example plugins, which have the same layout.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 825218b | Commit Preview URL Branch Preview URL |
Jun 28 2026, 01:51 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 825218b | Jun 28 2026, 01:52 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Toolkits content header sits ~12px higher than the sidebar header, so their bottom borders don't line up:
Root cause
The Tailwind v4
@sourceglobs only scanned plugin UI underplugins/*/src/react/**. The toolkits plugin keeps its UI directly insrc/(page.tsx,client.tsx), so Tailwind never scanned those files and any utility class used only there was silently dropped from the generated CSS.The content header at
packages/plugins/toolkits/src/page.tsxusesmin-h-12, which is used nowhere else in the codebase. It was never generated, so the header lost its 48px floor and collapsed to ~36px (py-2+ one line) while the sidebar'sh-12stayed 48px.Confirmed from the built CSS:
min-h-12,min-h-36, andspace-y-7were all absent, each used only in the toolkits plugin. (min-h-36was masked in the running app by an inlineminHeight: 9remfallback on the card; the header had no such fallback.)Fix
Widen the glob to
plugins/*/src/**so all plugin UI is scanned regardless of whether it lives undersrc/react. This also covers thedesktop-settingsandexampleplugins, which have the samesrc/-not-src/react/layout.Verification
Rebuilt
apps/localand confirmedmin-h-12,min-h-36, andspace-y-7now generate. Visual before/after (real compiled CSS around the real header markup) shows both header borders landing on the 48px baseline.