Fix cramped spacing in MCP install card header#1166
Merged
Conversation
The 'Connect an agent' card jammed its divider border and code block against the surrounding content: the header used pt-4 pb-1, so the subtitle sat only 4px above the divider, and the body used pt-1, leaving the code block ~4px below it. Balance the header (py-4, equal 16px top and bottom) and give the code block room below the divider (pt-1 to pt-3).
| const body = ( | ||
| <CardStackContent> | ||
| <div className="px-4 pt-1 pb-3"> | ||
| <div className="px-4 pt-3 pb-3"> |
There was a problem hiding this comment.
Since
pt-3 and pb-3 are now equal, they can be collapsed into the py-3 shorthand — consistent with how the header was just simplified from pt-4 pb-1 to py-4.
Suggested change
| <div className="px-4 pt-3 pb-3"> | |
| <div className="px-4 py-3"> |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Connect an agent" card (
McpInstallCard) crowded its divider border and code block against the surrounding content.Two spacing issues in the header/body:
pt-4 pb-1, so the subtitle sat only ~4px above the divider border, while the title had ~17px above it. Unbalanced.pt-1, leaving the code block jammed ~4px below that divider.Fix (two one-class edits in
mcp-install-card.tsx):pt-4 pb-1->py-4: equal ~16px above the title and below the subtitle.pt-1->pt-3: the code block now sits ~13px below the divider instead of ~4px.The shared
CodeBlockcomponent is intentionally untouched; this is purely the card layout.Before
After