fix: publish @executor-js library packages on release - #138
Closed
RhysSullivan wants to merge 2 commits into
Closed
Conversation
The `@executor-js/core`, `@executor-js/sdk`, and `@executor-js/plugin-*` packages were never reachable by the release workflow: - All seven `@executor-js/plugin-*` packages were still in the changeset `ignore` list, so `changeset version` never bumped them. - The root `build:packages` script still had a stale `@executor/plugin-*` glob, so plugin dist output was never built for publish. - `changesets/action@v1` was invoked with `version:` only — no `publish:` step — and the CLI publish workflow only ships the executor wrapper. Fix by removing the public plugins from the ignore list, correcting the build glob, adding `scripts/publish-packages.ts` (which packs + publishes every public @executor-js package whose version is not already on npm), and wiring a new publish step into `release.yml` that runs whenever the Version Packages PR is merged. Library publish now runs in parallel with the existing CLI publish dispatch.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
executor-cloud | 62afec6 | Apr 09 2026, 09:16 PM |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 98ddb2f | Commit Preview URL Branch Preview URL |
Apr 09 2026, 09:23 PM |
`npm publish --provenance` requires each package.json to advertise a repository URL so the minted sigstore attestation can be tied to a specific source location. Add `license: "MIT"`, `repository` (with the monorepo `directory` subpath), `homepage`, and `bugs` to every public `@executor-js/*` package so the upcoming provenance publish step in `release.yml` can actually attach attestations instead of erroring out.
6 tasks
Collaborator
Author
|
Superseded by #142 — consolidated @executor-js/core + @executor-js/sdk into one package with dual entry points. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@executor-js/core,@executor-js/sdk, and@executor-js/plugin-*packages were never reachable by the release workflow:
@executor-js/plugin-*packages were still in the changesetignorelist, sochangeset versionnever bumped them.build:packagesscript still had a stale@executor/plugin-*glob, so plugin dist output was never built for publish.
changesets/action@v1was invoked withversion:only — nopublish:step — and the CLI publish workflow only ships the executor wrapper.
Fix by removing the public plugins from the ignore list, correcting the
build glob, adding
scripts/publish-packages.ts(which packs + publishesevery public @executor-js package whose version is not already on npm),
and wiring a new publish step into
release.ymlthat runs whenever theVersion Packages PR is merged. Library publish now runs in parallel with
the existing CLI publish dispatch.