Gate self-host docker publish on the e2e suite#1392
Merged
Conversation
The publish workflow pushed user-visible tags after only building the image, so a startup crash (v1.5.30's missing worker-bundler) or any feature-path break could ship. Add an e2e job between build and merge that pulls each arch's by-digest image and runs the full selfhost-docker vitest project against it on a matching runner; merge (the step that moves latest/version tags) now requires it. Also switch the selfhost-docker target to the same forcedMcpConsent completion the selfhost dev target uses: the app forces prompt=consent on every MCP authorize, so authorize redirects to the relative /mcp-consent screen and mcporter's cookieConsentStrategy throws on the relative URL. The oauth-client-handoff scenarios failed against the production image because of this.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 42829b7 | Commit Preview URL Branch Preview URL |
Jul 10 2026, 06:46 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker publish workflow only built the image before moving user-visible tags, which is how v1.5.30 shipped with a startup crash. This adds an e2e job between build and merge: it pulls each arch's by-digest image and runs the selfhost-docker vitest project against it, so the latest/version tags only move if the real scenario suite passes on both amd64 and arm64.
Also fixes the selfhost-docker e2e target's MCP consent: it still used mcporter's cookieConsentStrategy, which throws on the relative /mcp-consent redirect the app now issues (the selfhost dev target already handles this via forcedMcpConsent — reuse it).