Add /connect/:integrationSlug deep links - #1466
Closed
RhysSullivan wants to merge 2 commits into
Closed
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 966a657 | Jul 28 2026, 08:43 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 966a657 | Commit Preview URL Branch Preview URL |
Jul 28 2026, 08:41 AM |
This was referenced Jul 28, 2026
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
platform-view-reach
branch
from
July 28, 2026 02:08
85ccaa1 to
6975511
Compare
RhysSullivan
force-pushed
the
connect-deep-links
branch
from
July 28, 2026 08:39
f975c8a to
966a657
Compare
This was referenced Jul 28, 2026
RhysSullivan
force-pushed
the
platform-view-reach
branch
from
July 29, 2026 02:44
6975511 to
94b961e
Compare
RhysSullivan
force-pushed
the
connect-deep-links
branch
from
July 29, 2026 02:44
966a657 to
5be906b
Compare
RhysSullivan
force-pushed
the
platform-view-reach
branch
from
July 29, 2026 02:58
11ac8fa to
33f410b
Compare
Resolves the slug against the tenant catalog and forwards into the integration detail page's existing add-connection flow. Unknown slugs get a not-found state. Makes the link survive sign-in: reserve connect as an org slug so cloud's callback stops reading it as an org selector, and return self-host's login to the requested path (its gate swaps the page in without ever writing a returnTo).
RhysSullivan
force-pushed
the
connect-deep-links
branch
from
July 29, 2026 02:58
5be906b to
cce2a24
Compare
Collaborator
Author
|
Consolidated into #1469. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1465 (shares the branch point; no dependency on its code). Adds a slug-based connect deep link to the shared console routes: resolves against the tenant catalog and redirects into the existing add-account flow (
?tab=accounts&addAccount=1). Survives sign-in on cloud (reservesconnectfrom org-slug parsing) and self-host (login now returns to the live location instead of hardcoded/). e2e scenario green on cloud and selfhost targets.Stack