Functional trays, Advancements, shitton of fixes and some QoL#5
Merged
Conversation
+ Add Manual Trigger advancement criterion; + Add Datagen for advancements; + Add 4 advancements; + Add gold tray and rename old one to iron tray; + Adapt bundle code to not have a "weight" limit; + Add placing and picking up plates with trays; + Configure advancements detections for manual trigger; * Add translations for new stuff; * Bump patch version;
- Added mixin and accesstransformers. - Modified BEWLR class so it works with the new system. - Added "DinnerwareBEWLRManager" to handle BEWLRs internally and their registration. - Added "FMLClientSetupEvent" to "ModEventBusClientEvents", its used to register the custom BEWLR. - Removed forge BEWLR logic from "PlateBlockBlockItem". - Added helper method in "TrayItem" that retrieves the games partialTick, to fix the model from jittering. - Added "ItemRendererMixin" that applies the custom BEWLRs (see class for more details). - Added a custom "registry object", its essentially just a supplier that can be used to lazily initialize an object, which upon creation gets cached. - removed: "parent": "builtin/entity" from the tray item model, as its no longer needed or wanted. - Added mixins json. - Added accesstransformer file.
…ments Custom BEWLR system and fixes
… wherever possible. * Fix bottom plate being too low and clipping through the tray now that its visible * Add andrew0030 to credits
- Fixed "QUICK_CRAFT" advancement not getting triggered, by implementing an internal cache to keep track of what slots are being changed. After all other logic has finished, it is then used to determine if an item was inserted that should trigger the advancement. - Cleaned up "PlateMenu" code. - Added a new accesstransformer for "quickcraftSlots".
…ments Fixed "QUICK_CRAFT" advancement trigger
* Fix tray sounds not playing when picking up plates in world; * Configure tray to use Pickup sound for loading, no sound for unloading and use bundle sounds in inventory; * Fix plate placing sound not playing; * Configure sounds.json a bit; * Fix tray placing a plate inside entity; * Bump patch-version, ever closer to release.
…if they can be placed inside and apply it: + Add config field; + Add relaxed validation to only crash if user added some bs to the list; + Add translatable blacklist message; * Apply blacklist check to eating attempt; * Apply blacklist check to slot fetching for both non-aim eating modes; * Fix description id for subtitles.
+ Add trayDynamicPlateOffset config option; * Pass displayContext from BEWLR to helper method; + Add logic to plates positioning code to offset plates. More info in the comments in the methods themselves.
…d fragile-breaking: * Rewrite entityInside to actually check plate AABB and only from sides/top; * Fix entity-in-block check to check for plate AABB + some graze instead of a whole ass block space; * Add missing advancement check on GUI actions; * Bump patch version
+ Add burnTime field and override the burnTime method; + Add constructor with burn time param, default one now sets 0; * Adjust wooden plates constructors;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+ Add gold tray and rename old one to iron tray;
* Update tray model, courtesy of QueeZeR
+ Add placing and picking up plates with trays;
+ Add Manual Trigger advancement criterion;
+ Add 4 advancements and Datagen;
+ Add tags for mod items, apply them instead of arrays/sets iteration wherever possible.
+ Add "Food Blacklist" option to forbid eating items inside it, even if they can be placed inside and apply it;
+ Add Dynamic offset for plate towers (5-16) on trays;
+ Add trayDynamicPlateOffset config option;
* Rewrite entityInside to actually check plate AABB and only from sides/top;
* Fix entity-in-block check to check for plate AABB + some graze instead of a whole ass block space;
+ Add 'fragile_plate_ignored' tag;
* Partially fix recipe datagen (iron plate messing bucket recipe)
* Semi-fix recipe unlock criteria shitting itself because of tags
+ Make wooden plates can be used as fuel for 0.75 of an item.
* Fix description id for subtitles.
* Configure sounds.json a bit;
* Add translations for new stuff;
* Merge #3 and #4 by andrew0030 with Tray BEWLR and advancement detection fixes;
* Add andrew0030 to credits;
* Update ReadMe-s;
* Bump patch version a few times.
Also includes commented out and unused draft for
cutfuture features.