use scikit instead of torchmcubes

[flowtyone]

Increase usability by using scikit-image instead of the old torchmcubes. This makes the project much easier to install and test.

[mrbid]

Increase usability by using scikit-image instead of the old torchmcubes. This makes the project much easier to install and test.

Just out of interest are there any obvious quality benefits over using scikit-image or is this mostly just an installing and testing solution? Speed benefits, wider range of GPU support etc? It would be interesting to actually see a full comparison between the two.

[flowtyone]

@mrbid speed wasn't impacted in my tests. The issue with torchmcubes is that it lacks prebuilt wheels and has a dependency issue with torch that makes it harder to install

[math-sasso]

@flowtyone how did you actually solved the problem? If you share a step by step would help a lot. I am struggling a lot to make it work

[flowtyone]

@math-sasso this PR works, just use my fork branch, it has these changes

[mrbid]

https://github.com/flowtyone/TripoSR/commit/341657e34f98f314cdfdcfbabe689d0d52dde7a5

It's quite a minimal and elegant patch. No need to even fork it tbh. This should be merged as an optional function in TripoSR, allowing the user to select which is used - ofc that wont solve the dependency issue, and I don't know if there is a similar ifdef system in Python as there is in C.

[mrbid]

I have an error with your fork:

Traceback (most recent call last):
  File "/home/r/Desktop/TripoSR-use-scikit/run.py", line 32, in <module>
    mesh = model.extract_mesh(scene_codes, resolution=256)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/r/Desktop/TripoSR-use-scikit/tsr/system.py", line 172, in extract_mesh
    self.set_marching_cubes_resolution(resolution)
  File "/home/r/Desktop/TripoSR-use-scikit/tsr/system.py", line 169, in set_marching_cubes_resolution
    self.isosurface_helper = MarchingCubeHelper(resolution)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/r/Desktop/TripoSR-use-scikit/tsr/models/isosurface.py", line 20, in __init__
    self.mc_func: Callable = marching_cubes
                             ^^^^^^^^^^^^^^
NameError: name 'marching_cubes' is not defined

I was going to bench it against the original and this modified version by @thatname here: #22 (comment)

[TimCabbage]

@mrbid @flowtyone
To make it work, one more change is needed:
the line:
self.mc_func: Callable = marching_cubes
Needs to be removed.

Works on ROCM with this change.