fix handling of shutdown request and exit notification #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhdl_ls did not quit/exit after receiving the shutdown request and exit notification, because the lsp_server handle_shutdown request already waits for the exit notification and only returns true, if it is received. With the old setup the handler for the exit notification was never called, because handle_shutdown consumed the notification. fixes VHDL-LS#142
Gaweringo
force-pushed
the
lsp-shutdown
branch
from
edc4607 to
6a1d879
Compare
Contributor
|
Thanks for the effort! Let's hope this fixes the issue once and for all ;) |
|
I confirm it appears to be finally fixed now. Tested in Neovim. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vhdl_ls did not quit/exit after receiving the shutdown request and exit notification, because the lsp_server handle_shutdown request already waits for the exit notification and only returns true, if it is received.
With the old setup, the handler for the exit notification was never called, because handle_shutdown consumed the notification.
fixes #142