Skip to content

feat(DateRangeInput,DateInput,CustomSelect): turn on accessible flag by default#9194

Merged
EldarMuhamethanov merged 3 commits intomasterfrom
e.muhamethanov/8972/accesible-on-by-default
Nov 25, 2025
Merged

feat(DateRangeInput,DateInput,CustomSelect): turn on accessible flag by default#9194
EldarMuhamethanov merged 3 commits intomasterfrom
e.muhamethanov/8972/accesible-on-by-default

Conversation

@EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

В компонентах DateRangeInput, DateInput и CustomSelect есть свойство accessible, которое по умолчанию сейчас false. Нужно сделать, чтобы по умолчанию этот флаг был включен.

Изменения

  • В DateRangeInput, DateInput и CustomSelect включил флаг accessible по умолчанию.
  • Поправил тесты, чтобы не падали
  • Также оставил TODO на выпил этих флагов в v9

Release notes

BREAKING CHANGE

  • DateInput: флаг accessible теперь включен по умолчанию
  • DateRangeInput: флаг accessible теперь включен по умолчанию
  • CustomSelect: флаг accessible теперь включен по умолчанию

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

size-limit report 📦

Path Size
JS 426.56 KB (+0.01% 🔺)
JS (gzip) 129.08 KB (+0.02% 🔺)
JS (brotli) 105.62 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.5 KB (0%)
CSS (gzip) 45.84 KB (0%)
CSS (brotli) 36.32 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit ec6f58e

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9194/ec6f58e8b3f15eeb765cdeda69734dcc1ec81c8b/pkg/@vkontakte/vkui/_pkg.tgz

Commit ec6f58e

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@33e96df). Learn more about missing BASE report.
⚠️ Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #9194   +/-   ##
=========================================
  Coverage          ?   95.03%           
=========================================
  Files             ?      420           
  Lines             ?    11208           
  Branches          ?     4221           
=========================================
  Hits              ?    10652           
  Misses            ?      556           
  Partials          ?        0           
Flag Coverage Δ
unittests 95.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SevereCloud
SevereCloud previously approved these changes Nov 24, 2025
@EldarMuhamethanov EldarMuhamethanov merged commit c82337e into master Nov 25, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8972/accesible-on-by-default branch November 25, 2025 12:10
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Nov 25, 2025
@inomdzhon inomdzhon added the v8 label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants