feat(CalendarTime): remove reset accessible to false#9215
Merged
EldarMuhamethanov merged 2 commits intomasterfrom Nov 28, 2025
Merged
feat(CalendarTime): remove reset accessible to false#9215EldarMuhamethanov merged 2 commits intomasterfrom
EldarMuhamethanov merged 2 commits intomasterfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9215/816ddec8cb6b03da7a037ed0affa5b5a84179583/pkg/@vkontakte/vkui/_pkg.tgzCommit 816ddec |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9215 +/- ##
=======================================
Coverage 95.03% 95.04%
=======================================
Files 420 421 +1
Lines 11208 11209 +1
Branches 4221 4221
=======================================
+ Hits 10652 10654 +2
+ Misses 556 555 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
approved these changes
Nov 26, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/9194/remove-accessible-flag-reset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
После того как в #9194 в
CustomSelectфлаг accessible был включен по умолчанию, немного поломалост поведение пикеров времени вCalendar. Поэтому было решено временно проставитьaccessible={false}. Нужно избавиться от сбросаaccessibleтак как вv9этот флаг будет удален.Изменения
CalendarTimePicker.CalendarTimePickerдоработал логику так чтобы ввода даты работал корректно. По итоге получилось так, что a11y этого компонента стал лучше.Release notes