Revisiting "Clear SRAnipal logs on initialize" #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revisiting regzo2's log clear fix with changes suggested by benaclejames
Removed the indentation entirely to match the other enum declaration files.
This reverts commit aaf51e4.
Contributor
Author
|
I messed up my commits yet again, but reverted the changes. Those are from another branch of small changes. |
Contributor
Author
|
I don't think this will work because SRanipal has a lock on the log files. @regzo2 original solution makes more sense I think. |
Brought back regzo2's method of clearing the file so we don't try to delete a file SRanipal is currently writing to.
Contributor
|
closes #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting regzo2's log clear fix with changes suggested by benaclejames